Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not correct string number #34

Open
tigertv opened this issue Nov 9, 2020 · 3 comments
Open

Not correct string number #34

tigertv opened this issue Nov 9, 2020 · 3 comments
Labels

Comments

@tigertv
Copy link

tigertv commented Nov 9, 2020

Bigint a("m");

The following code gives a loop.

@kasparsklavins
Copy link
Owner

kasparsklavins commented Nov 9, 2020

Runnable example

"m" isnt a valid argument. What output do you expect?

Can either:

  1. Throw
  2. Cast to 0

I'm leaning mostly towards (1)

@tigertv
Copy link
Author

tigertv commented Nov 9, 2020

Exception, not a loop.

@Qix-
Copy link

Qix- commented Nov 19, 2021

Throwing makes the most sense, or in the case that -fno-exceptions is on, then std::abort() and document that invalid input is simply not tolerated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants