Updates for 0.7 release #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mattiasb
commented
Jan 3, 2014
mattiasb
commented
- Use the exact same jshintrc as Leaflet
- Add karma testing and jshint to Gruntfile
- Remove the submodules mess (and use npm dependencies instead
- Update Leaflet dependency
- Port the IE quirks over to the new leaflet-oldie-classes
Use the same jshintrc as Leaflet, and fix all errors.
Add myself to copyright notice and add a license field to package.json.
Add grunt-contrib-jshint task to grunt and add it to the default task.
Update README.md
Use node packages instead of git submodules for the developer dependencies. This means using the Leaflet npm module and not using leaflet-tilejson anymore. This patch, by incident, also fixes all examples to explicitly load the zoomslider since it doesn't load automatically anymore since 0.6.2.
Remove jake (since we use grunt now) and uglify-js (since we don't use that at all).
Use the grunt karma task instead of our own hand rolled one.
Update Leaflet to 0.7.1
Make a conditional check for console.log in test2.html
Leaflet 0.7.x doesn't use specific styles for IE anymore and also drops support for IE6. This commits does the same for us.
Bump version to 0.7.0
|
Nice! Using NPM instead of submodules is much cleaner. |
|
Indeed. :) |
|
Good idea. Do you have a npm user, and what is the username? (https://npmjs.org/doc/cli/npm-adduser.html otherwise) |
|
mattiasb :) |
|
Ok :) Added you as owner, so you should be able to publish in the future. Also, I published 0.7.0. |
|
Nice thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.