L.Control.Zoomslider.js : update _onSliderClick() function #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Best use of L.DomEvent.getMousePosition() function.
|
This looks good. I need to test this before applying though. So hopefully tomorrow. Please ping me if I seem to forget. |
|
Don't forget the patch please :-) ! |
|
Ooo! You forget me... I'm so sad :-) |
|
I haven't forgotten about you btw. Some personal stuff has come in the way and I want to test this on the IE's and FF before applying. Plus look at the relevant Leaflet code. |
|
The patch works on Chrome 29, Internet Explorer 10, Firefox 23 & 24 |
mattiasb
added a commit
that referenced
this pull request
Oct 31, 2013
L.Control.Zoomslider.js : update _onSliderClick() function
|
Just tested this, and it seems to work fine. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code of
_onSliderClick()function doesn't work with Leaflet 6.4 (becausegetMousePosition()needs a container as 2nd parameter).My correction does the job with Leaflet 6.2 to 6.4 and 7.0-dev (master) !