Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make priorityClassSource in the SchedulePriority of PropagationPolicy a required field #6163

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

seanlaii
Copy link
Contributor

What type of PR is this?
/kind api-change
/kind feature

What this PR does / why we need it:
Making it a required field allows for more flexibility in future changes. For example, if we need to modify the default value later, we can make it optional and explicitly define a default value.

Which issue(s) this PR fixes:
Part of #5961

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Make priorityClassSource in the SchedulePriority of PropagationPolicy a required field.

@karmada-bot karmada-bot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Feb 26, 2025
@karmada-bot karmada-bot added kind/feature Categorizes issue or PR as related to a new feature. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 26, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.11%. Comparing base (7b29afb) to head (ac22188).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6163   +/-   ##
=======================================
  Coverage   48.11%   48.11%           
=======================================
  Files         668      668           
  Lines       55344    55344           
=======================================
+ Hits        26626    26629    +3     
+ Misses      26982    26980    -2     
+ Partials     1736     1735    -1     
Flag Coverage Δ
unittests 48.11% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2025
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2025
@karmada-bot karmada-bot merged commit ce5be5e into karmada-io:master Feb 27, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants