Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): detection new MS Edge Chromium #3440

Merged
merged 1 commit into from
Mar 23, 2020
Merged

fix(server): detection new MS Edge Chromium #3440

merged 1 commit into from
Mar 23, 2020

Conversation

anthony-redFox
Copy link
Contributor

BREAKING CHANGES - Browser and OS name generation are changed
swich on new lib ua-parser-js to have a good detection of MS Edge Chromium

@karmarunnerbot
Copy link
Member

✅ Build karma 112 completed (commit f40d1d6b49 by @anthony-redFox)

@karmarunnerbot
Copy link
Member

✅ Build karma 111 completed (commit f40d1d6b49 by @anthony-redFox)

@karmarunnerbot
Copy link
Member

✅ Build karma 113 completed (commit 56aae50f5f by @anthony-redFox)

@karmarunnerbot
Copy link
Member

✅ Build karma 112 completed (commit 56aae50f5f by @anthony-redFox)

@karmarunnerbot
Copy link
Member

✅ Build karma 114 completed (commit 09cea691fa by @anthony-redFox)

@karmarunnerbot
Copy link
Member

✅ Build karma 113 completed (commit 09cea691fa by @anthony-redFox)

@AppVeyorBot
Copy link

✅ Build karma 2510 completed (commit f40d1d6b49 by @anthony-redFox)

@AppVeyorBot
Copy link

✅ Build karma 2511 completed (commit 56aae50f5f by @anthony-redFox)

@AppVeyorBot
Copy link

✅ Build karma 2512 completed (commit 09cea691fa by @anthony-redFox)

@anthony-redFox anthony-redFox reopened this Mar 6, 2020
@AppVeyorBot
Copy link

✅ Build karma 2513 completed (commit 72cd0bb24d by @anthony-redFox)

@karmarunnerbot
Copy link
Member

✅ Build karma 115 completed (commit 72cd0bb24d by @anthony-redFox)

@karmarunnerbot
Copy link
Member

✅ Build karma 114 completed (commit 72cd0bb24d by @anthony-redFox)

@AppVeyorBot
Copy link

✅ Build karma 2514 completed (commit 4e0c5b3b9f by @anthony-redFox)

@karmarunnerbot
Copy link
Member

✅ Build karma 116 completed (commit 4e0c5b3b9f by @anthony-redFox)

@karmarunnerbot
Copy link
Member

✅ Build karma 115 completed (commit 4e0c5b3b9f by @anthony-redFox)

@karmarunnerbot
Copy link
Member

✅ Build karma 117 completed (commit 3752aaefa7 by @anthony-redFox)

@AppVeyorBot
Copy link

✅ Build karma 2515 completed (commit 3752aaefa7 by @anthony-redFox)

@karmarunnerbot
Copy link
Member

✅ Build karma 116 completed (commit 3752aaefa7 by @anthony-redFox)

@AppVeyorBot
Copy link

✅ Build karma 2516 completed (commit 8e9be042b3 by @anthony-redFox)

@karmarunnerbot
Copy link
Member

✅ Build karma 118 completed (commit 8e9be042b3 by @anthony-redFox)

@karmarunnerbot
Copy link
Member

✅ Build karma 117 completed (commit 8e9be042b3 by @anthony-redFox)

@anthony-redFox
Copy link
Contributor Author

@johnjbarton please take a look on our(and @devoto13) PRs

abaksha-sc
abaksha-sc reviewed Mar 6, 2020
View reviewed changes
lib/helper.js Outdated Show resolved Hide resolved
@karmarunnerbot
Copy link
Member

✅ Build karma 128 completed (commit 2401b6ee70 by @johnjbarton)

@AppVeyorBot
Copy link

✅ Build karma 2526 completed (commit 3b2e60a234 by @johnjbarton)

@karmarunnerbot
Copy link
Member

✅ Build karma 127 completed (commit 3b2e60a234 by @johnjbarton)

johnjbarton
johnjbarton suggested changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(just putting something in here to get github to change state)

This commit looks good but not the other one.

@anthony-redFox
fix(server): detection new MS Edge Chromium
a49924c 
BREAKING CHANGES - Browser and OS name generation are changed
swich on new lib ua-parser-js to have a good detection of MS Edge Chromium
@karmarunnerbot
Copy link
Member

✅ Build karma 130 completed (commit de5a9d27d8 by @anthony-redFox)

@AppVeyorBot
Copy link

✅ Build karma 2529 completed (commit de5a9d27d8 by @anthony-redFox)

@karmarunnerbot
Copy link
Member

✅ Build karma 131 completed (commit de5a9d27d8 by @anthony-redFox)

johnjbarton
johnjbarton approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@johnjbarton johnjbarton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@johnjbarton johnjbarton merged commit 7166ce2 into karma-runner:master Mar 23, 2020
@devoto13 devoto13 mentioned this pull request Apr 3, 2020
Closed
karmarunnerbot pushed a commit that referenced this pull request Apr 9, 2020
@semantic-release-bot
chore(release): 5.0.0 [skip ci]
1b48637 
# [5.0.0](v4.4.1...v5.0.0) (2020-04-09)

### Bug Fixes

* install semantic-release as a regular dev dependency ([#3455](#3455)) ([1eaf35e](1eaf35e))
* **ci:** echo travis env that gates release after_success ([#3446](#3446)) ([b8b2ed8](b8b2ed8))
* **ci:** poll every 10s to avoid rate limit. ([#3388](#3388)) ([91e7e00](91e7e00))
* **middleware/runner:** handle file list rejections ([#3400](#3400)) ([80febfb](80febfb)), closes [#3396](#3396) [#3396](#3396)
* **server:** cleanup import of the removed method ([#3439](#3439)) ([cb1bcbf](cb1bcbf))
* **server:** createPreprocessor was removed ([#3435](#3435)) ([5c334f5](5c334f5))
* **server:** detection new MS Edge Chromium ([#3440](#3440)) ([7166ce2](7166ce2))
* **server:** replace optimist on yargs lib ([#3451](#3451)) ([ec1e69a](ec1e69a)), closes [#2473](#2473)
* **server:** Report original error message ([#3415](#3415)) ([79ee331](79ee331)), closes [#3414](#3414)

### Code Refactoring

* use native Promise instead of Bluebird ([#3436](#3436)) ([33a069f](33a069f)), closes [/github.com//pull/3060#discussion_r284797390](https://github.com//github.com/karma-runner/karma/pull/3060/issues/discussion_r284797390)

### Continuous Integration

* drop node 8, adopt node 12 ([#3430](#3430)) ([a673aa8](a673aa8))

### Features

* **docs:** document `DEFAULT_LISTEN_ADDR` constant ([#3443](#3443)) ([057d527](057d527)), closes [#2479](#2479)
* **karma-server:** added log to the server.js for uncaught exception ([#3399](#3399)) ([adc6a66](adc6a66))
* **preprocessor:** obey Pattern.isBinary when set ([#3422](#3422)) ([708ae13](708ae13)), closes [#3405](#3405)

### BREAKING CHANGES

* Karma plugins which rely on the fact that Karma uses Bluebird promises may break as Bluebird-specific API is no longer available on Promises returned by the Karma core
* **server:** Deprecated createPreprocessor removed, karma-browserify < 7 version doesn't work
* no more testing on node 8.
@karmarunnerbot
Copy link
Member

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

babot pushed a commit to binaryage/dirac that referenced this pull request Apr 15, 2020
@TimvdLippe
Update Karma to 5.0.1
60e778e 
The breaking changes listed in
https://github.com/karma-runner/karma/releases/tag/v5.0.0 do not
apply to us.

This should also include support for Edgium per
karma-runner/karma#3440

[email protected]
DISABLE_THIRD_PARTY_CHECK=Update karma

Bug: 1068145
Change-Id: I7567b2db14dbf59aaf9c091220157bf55d155810
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2144050
Commit-Queue: Jack Franklin <[email protected]>
Reviewed-by: Jack Franklin <[email protected]>
Auto-Submit: Tim van der Lippe <[email protected]>
devtools-bot pushed a commit to ChromeDevTools/devtools-frontend that referenced this pull request Apr 15, 2020
@TimvdLippe
Update Karma to 5.0.1
ef99162 
The breaking changes listed in
https://github.com/karma-runner/karma/releases/tag/v5.0.0 do not
apply to us.

This should also include support for Edgium per
karma-runner/karma#3440

[email protected]
DISABLE_THIRD_PARTY_CHECK=Update karma

Bug: 1068145
Change-Id: I7567b2db14dbf59aaf9c091220157bf55d155810
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2144050
Commit-Queue: Jack Franklin <[email protected]>
Reviewed-by: Jack Franklin <[email protected]>
Auto-Submit: Tim van der Lippe <[email protected]>
@karronoli karronoli mentioned this pull request Aug 16, 2022
Merged
anthony-redFox added a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
@anthony-redFox
fix(server): detection new MS Edge Chromium (karma-runner#3440)
56e65c2 
BREAKING CHANGES - Browser and OS name generation are changed
switch to new lib ua-parser-js, which has better detection of MS Edge Chromium
anthony-redFox pushed a commit to anthony-redFox/karma that referenced this pull request May 16, 2023
@semantic-release-bot @anthony-redFox
chore(release): 5.0.0 [skip ci]
d4e245c 
# [5.0.0](karma-runner/karma@v4.4.1...v5.0.0) (2020-04-09)

### Bug Fixes

* install semantic-release as a regular dev dependency ([karma-runner#3455](karma-runner#3455)) ([1eaf35e](karma-runner@1eaf35e))
* **ci:** echo travis env that gates release after_success ([karma-runner#3446](karma-runner#3446)) ([b8b2ed8](karma-runner@b8b2ed8))
* **ci:** poll every 10s to avoid rate limit. ([karma-runner#3388](karma-runner#3388)) ([91e7e00](karma-runner@91e7e00))
* **middleware/runner:** handle file list rejections ([karma-runner#3400](karma-runner#3400)) ([80febfb](karma-runner@80febfb)), closes [karma-runner#3396](karma-runner#3396) [karma-runner#3396](karma-runner#3396)
* **server:** cleanup import of the removed method ([karma-runner#3439](karma-runner#3439)) ([cb1bcbf](karma-runner@cb1bcbf))
* **server:** createPreprocessor was removed ([karma-runner#3435](karma-runner#3435)) ([5c334f5](karma-runner@5c334f5))
* **server:** detection new MS Edge Chromium ([karma-runner#3440](karma-runner#3440)) ([7166ce2](karma-runner@7166ce2))
* **server:** replace optimist on yargs lib ([karma-runner#3451](karma-runner#3451)) ([ec1e69a](karma-runner@ec1e69a)), closes [karma-runner#2473](karma-runner#2473)
* **server:** Report original error message ([karma-runner#3415](karma-runner#3415)) ([79ee331](karma-runner@79ee331)), closes [karma-runner#3414](karma-runner#3414)

### Code Refactoring

* use native Promise instead of Bluebird ([karma-runner#3436](karma-runner#3436)) ([33a069f](karma-runner@33a069f)), closes [/github.com/karma-runner/pull/3060#discussion_r284797390](https://github.com//github.com/karma-runner/karma/pull/3060/issues/discussion_r284797390)

### Continuous Integration

* drop node 8, adopt node 12 ([karma-runner#3430](karma-runner#3430)) ([a673aa8](karma-runner@a673aa8))

### Features

* **docs:** document `DEFAULT_LISTEN_ADDR` constant ([karma-runner#3443](karma-runner#3443)) ([057d527](karma-runner@057d527)), closes [karma-runner#2479](karma-runner#2479)
* **karma-server:** added log to the server.js for uncaught exception ([karma-runner#3399](karma-runner#3399)) ([adc6a66](karma-runner@adc6a66))
* **preprocessor:** obey Pattern.isBinary when set ([karma-runner#3422](karma-runner#3422)) ([708ae13](karma-runner@708ae13)), closes [karma-runner#3405](karma-runner#3405)

### BREAKING CHANGES

* Karma plugins which rely on the fact that Karma uses Bluebird promises may break as Bluebird-specific API is no longer available on Promises returned by the Karma core
* **server:** Deprecated createPreprocessor removed, karma-browserify < 7 version doesn't work
* no more testing on node 8.
This was referenced Jan 1, 2024
Open
Open
@Omrisnyk Omrisnyk mentioned this pull request Feb 2, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Feb 11, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Mar 15, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request May 28, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Jun 19, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Jul 2, 2024
Open
@Omrisnyk Omrisnyk mentioned this pull request Oct 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abaksha-sc abaksha-sc abaksha-sc left review comments

@johnjbarton johnjbarton johnjbarton approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anthony-redFox @karmarunnerbot @AppVeyorBot @johnjbarton @abaksha-sc