Skip to content

Commit

Permalink
fix(server): actually call stert(). (#3062)
Browse files Browse the repository at this point in the history
Warn that the function without a test will be removed
  • Loading branch information
johnjbarton authored Jun 21, 2018
1 parent 414b84c commit 40d836a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
3 changes: 2 additions & 1 deletion lib/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,8 @@ class Server extends KarmaEventEmitter {
}

static start (cliOptions, done) {
return new Server(cliOptions, done)
console.warn('Deprecated static method to be removed in v3.0')
return new Server(cliOptions, done).start()
}
}

Expand Down
4 changes: 0 additions & 4 deletions test/unit/server.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,4 @@ describe('server', () => {
}
})
})

it('static Server constructs a server', () => {
expect(Server.start(mockConfig) instanceof Server).to.be.true
})
})

0 comments on commit 40d836a

Please sign in to comment.