From 98a4ada68f1c4b83589c39b2573ba760a371cbd0 Mon Sep 17 00:00:00 2001 From: Leonardo Val Date: Thu, 7 Dec 2017 13:56:22 -0300 Subject: [PATCH] fix: safe handling of missing env variables On Windows 7 the launcher will not load, throwing the error `Cannot read property 'substr' of undefined`. This was caused by an undefined prefix at `getAllPrefixes()`. Closes #67 --- index.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/index.js b/index.js index 6722ff8..fd25446 100644 --- a/index.js +++ b/index.js @@ -33,10 +33,12 @@ var getAllPrefixes = function () { var prefixes = [process.env.PROGRAMFILES, process.env['PROGRAMFILES(X86)']] var prefix for (var i = 0; i < prefixes.length; i++) { - for (var d = 0; d < drives.length; d += 1) { - prefix = drives[d] + prefixes[i].substr(1) - if (result.indexOf(prefix) === -1) { - result.push(prefix) + if (typeof prefixes[i] !== 'undefined') { + for (var d = 0; d < drives.length; d += 1) { + prefix = drives[d] + prefixes[i].substr(1) + if (result.indexOf(prefix) === -1) { + result.push(prefix) + } } } }