New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should be able to drag the main lyric text to generate the ruby/romaji text. #2007

Closed

andy840119 opened this issue May 13, 2023 · 5 comments

Labels

Milestone

Member

andy840119 commented May 13, 2023 •

edited

Loading

As title, instead of typing the start and end index in here, should be able to drag the the main text to create the ruby/romaji with start and end index.

andy840119 added the enhancement label

Member Author

andy840119 commented May 13, 2023

Guess can implement after #2008?

Member Author

andy840119 commented May 14, 2023 •

edited

Loading

Guess should wait after #2009?

[Update]
Implemented

This was referenced Jun 3, 2023

Implement base interface for able to change the end index caret position. #2022

Merged

Implement create ruby caret position algorithm. #2023

Merged

Refactor drawable caret layer. #2031

Merged

This was referenced Jun 16, 2023

Enable to combine lyric text into kanji and ruby in lyric editor. #458

Open

Able right-click to create new ruby/romaji object. #618

Closed

andy840119 mentioned this issue

Make typing caret draggable. #2099

Merged

Member Author

andy840119 commented Aug 15, 2023

After we have sample to drag range of the lyric and do the action (see: #2099)
Maybe it's a good start to continue this issue.

This was referenced Sep 3, 2023

Implement the sub-section for able to switch the edit mode in the lyric editor. #2110

Closed

Should be able to drag the main lyric text to generate the ruby/romaji text. #2112

Merged

Member Author

andy840119 commented Sep 4, 2023 •

edited

Loading

Remaining part:

Guess should be better to have the pop-up with ruby text input and create button after select the range of the text. Implement create ruby tag popover. #2126
- caret state should have bindable for able to record the release state. Change the drag caret position will not change the caret position. #2125
Need to show the popover if click the ruby tag, like how note edit area did. Create popover for able to edit ruby text. #2131
Create a hot-key for able to create ruby-tag if select the range. -> will open the popover after click or select range of the main text.
- E.g. create the ruby tag if select the range of the text and press "enter".
- Also, should show the description by edit mode switcher subsection.
It's time to remove the "add ruby" and "add romaji" button. Remove create ruby/romaji button. #2128

andy840119 mentioned this issue

Should be able to press "shift" to change the drag index. #2113

Open

andy840119 mentioned this issue

Change the drag caret position will not change the caret position. #2125

Merged

andy840119 added this to the 2023.1010 milestone

Member Author

andy840119 commented Sep 24, 2023

Guess it's enough to close this issue.

andy840119 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment