New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move LyricCheckerManager for lyric editor only? #1030

Closed

andy840119 opened this issue Jan 15, 2022 · 2 comments

Labels

code quality LyricMaker

Milestone

Member

andy840119 commented Jan 15, 2022

Because seems there's no other place need to check the lyric i guess.
Also, should re-calculate after lyric property changed.

andy840119 added code quality LyricMaker labels

Member Author

andy840119 commented Apr 2, 2022 •

edited

Loading

Not really sure would it be a good idea to merge the check manager into lyric provider after #1250.
Pros: Make the things simple and easy to access.
Cons: Not really sure will Lazer make this shit to global, means will have duplicated checking works. Also, it's not high priority i guess(?)

Member Author

andy840119 commented Aug 26, 2024

It's named LyricEditorVerifier or PageEditorVerifier (by different screen)
And it's belongs to it's own editor.

andy840119 closed this as completed

andy840119 added this to the 2024.0831 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment