Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template application macro issues #234

Open
teroparvinen opened this issue Aug 3, 2022 · 0 comments
Open

Template application macro issues #234

teroparvinen opened this issue Aug 3, 2022 · 0 comments

Comments

@teroparvinen
Copy link

There are a couple of simple to fix issues with the template application macro setup.

First, the documentation could probably use a mention that the on use macro should be of the "Before Active Effects" type.

Second, the macro in the compendium contains a <midi arguments here> placeholder that does not work, when it could simply have args there.

The applyTemplate function in AAhelpers.js also has two bugs:

First, let disposition = args[0].actor.token.disposition should be something like let disposition = args[0].actor.token?.data.disposition ?? 1 because the token field does not seem to be populated for actors with linked tokens and the disposition field is in data.

Second, the origin logic should be Actor.${args[0].actorData._id}.Item.${args[0].item._id} because the actor field points to an actor entity that has an id property, not _id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant