Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apollo Angular SSR use state transfer: not respect default cache policy cache-first, have to add manual on each request #1765

Open
hiepxanh opened this issue Mar 7, 2022 · 1 comment

Comments

@hiepxanh
Copy link

hiepxanh commented Mar 7, 2022

Describe the bug

As Apollo Client describe, it default policy is cache-first which is not really understand why not working on apollo angular universal if I use TransferState.

image

To Reproduce
Steps to reproduce the behavior:

  • add SSR and apollo-angular Store rehydration#
  • make request, it cached on server, check the request, it still make the request to server on client again.
  • console.log(this.apollo.client.cache.readQuery(query)) can see the cache result still here.
  • add cache-first to the query. Client apollo happy now and don't make request.

Expected behavior

  • I do not need to add cache-first on every request.
    I don't know is that by design or miss take. the Apollo Angular change it?
    if it by design. we should note the developer. "You should add fetchPolicy: 'cache-first' if you want your query read the cache from
    on the document.

Environment:

dependencies:
@angular/cli 13.1.2
@angular/core 13.2.1
@apollo/client 3.5.8
apollo-angular 3.0.0
graphql 15.8.0
typescript 4.5.4

Additional context

I'm willing to check source code. I already look in source code and don't find that Apollo Angular change anything relevant to fetchPolicy. I still cannot find the reason. I can make a PR which have some test case if you like. or an other PR for document if you think we need notice developer should add cache-first if you want to cache.
BTW, what is the default cache policy of Apollo Angular? did I miss something?

@PowerKiKi
Copy link
Collaborator

If it still happen, please make a PR, either for a failing test case, or for a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants