Skip to content
This repository has been archived by the owner on Apr 22, 2021. It is now read-only.

Fix Search performance #819

Closed
5HT2 opened this issue May 13, 2020 · 1 comment · Fixed by #1115
Closed

Fix Search performance #819

5HT2 opened this issue May 13, 2020 · 1 comment · Fixed by #1115
Labels
-low-priority Not gonna happen soon, but maybe someday it will -module enhancement
Milestone
v1.1.7

Comments

@5HT2
Copy link
Member

5HT2 commented May 13, 2020

thanks sakuya
@5HT2 5HT2 added this to the v1.1.4 milestone May 13, 2020
@5HT2 5HT2 self-assigned this May 13, 2020
@5HT2 5HT2 modified the milestones: v1.1.4, v1.1.5 May 19, 2020
@5HT2
Copy link
Member Author

5HT2 commented May 19, 2020

Moving to next version. For context, the way to improve it would be to use Baritone's ChunkUtils to search the chunk, instead of doing all the math ourselves, because our math sucks currently. Baritone already searches for blocks and it has a minimal impact on performance. See #430

@5HT2 5HT2 added the -low-priority Not gonna happen soon, but maybe someday it will label May 26, 2020
@5HT2 5HT2 modified the milestones: v1.1.5, low-priority May 26, 2020
@5HT2 5HT2 removed their assignment May 27, 2020
@Luna5ama Luna5ama mentioned this issue Aug 5, 2020
Merged
@5HT2 5HT2 linked a pull request Aug 8, 2020 that will close this issue
Render modules update and bug fixes #1115
Merged
@5HT2 5HT2 closed this as completed in #1115 Aug 8, 2020
@5HT2 5HT2 modified the milestones: low-priority, v1.1.7 Aug 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
-low-priority Not gonna happen soon, but maybe someday it will -module enhancement
Projects
None yet
Milestone
v1.1.7
Development

Successfully merging a pull request may close this issue.

Render modules update and bug fixes
1 participant
@5HT2