Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEV-1542): countdown shows 10 sec after reaching to 0 and after seeking #717

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

lianbenjamin
Copy link
Collaborator

@lianbenjamin lianbenjamin commented Jan 10, 2023

Description of the Changes

the issue:
countdown component shows 10 sec when it shouldn't. see below use-cases:

  1. when the player is about to switch to the next media, countdown reaches to 0 and then shows 10 before it disappears.
  2. when the countdown comp is rendered (seek to almost the end of the video so it will show for example 7 sec) and performing seeking to a position that the comp should not be rendered (seek to somewhere in the beginning of the video)- countdown shows 10 sec before it disappears.

solution:
add a validation to shouldRender() func -> check the value of timeToShow state.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@lianbenjamin lianbenjamin merged commit 2bbd07b into master Jan 17, 2023
@giladna giladna deleted the FEV-1542-countdown branch January 17, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants