Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-10615): support sending Kava beacons as POST #125

Merged
merged 2 commits into from
Oct 29, 2020
Merged

feat(FEC-10615): support sending Kava beacons as POST #125

merged 2 commits into from
Oct 29, 2020

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Oct 29, 2020 •
edited
Loading

Description of the Changes

add an optional param to send Kava beacons as POST

Solves FEC-10615

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team October 29, 2020 11:30
@yairans yairans self-assigned this Oct 29, 2020
OrenMe
OrenMe previously approved these changes Oct 29, 2020
View reviewed changes
@yairans yairans mentioned this pull request Oct 29, 2020
Merged
5 tasks
@yairans yairans merged commit 7fe3284 into master Oct 29, 2020
@yairans yairans deleted the FEC-10615 branch October 29, 2020 15:40
yairans added a commit to kaltura/playkit-js-kava that referenced this pull request Oct 29, 2020
@yairans
feat(FEC-10615): support sending Kava beacons as POST (#86)
5a9452c 
add `requestMethod` config (`GET` by default) and send it to `OVPAnalyticsService.trackEvent`

Depends on kaltura/playkit-js-providers#125

Solves FEC-10615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@yairans yairans

Labels
Priority: High Type: Feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yairans @OrenMe