feat(FEC-8391): checking if the quota exceeded error #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing the errors flow. fixing documentation.
fixing documentation.
OrenMe
suggested changes
Jul 15, 2018
src/shaka-offline-provider.js
Outdated
| }) | ||
| } | ||
|
|
||
| _getErrorData(error: any): any { |
src/shaka-offline-provider.js
Outdated
| }).catch((error) => { | ||
| reject(new Error(Error.Severity.RECOVERABLE, Error.Category.STORAGE, Error.Code.DOWNLOAD_ABORTED, error)); | ||
| }); | ||
| }).catch(error => |
src/offline-manager.js
Outdated
| }).catch((error) => { | ||
| this._onError(new Error(Error.Severity.RECOVERABLE, Error.Category.STORAGE, Error.Code.REMOVE_REJECTED, error)); | ||
| }); | ||
| }).catch(error => this._onError(error)); |
There was a problem hiding this comment.
if you return the inner promises can you just use catch on the outer most promise?
when there the index db cannot find the requested item - it returns an empty response and not rejects. it rejects only upon an error (e.g. when the key is an object instead of a string/int)
OrenMe
approved these changes
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checking if the error thrown (by the indexeddb handler or by shaka ) is because the quota of the db exceeded (no more free storage).
also refactored the errors. it was a bit of a mess.