Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10635): Add catch handler for Kava HTTP request #89

Merged
merged 2 commits into from
Nov 25, 2020
Merged

fix(FEC-10635): Add catch handler for Kava HTTP request #89

merged 2 commits into from
Nov 25, 2020

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Nov 12, 2020

Description of the Changes

handle promise rejection on send xhr analytics

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke
fix(FEC-10635): Add catch handler for Kava HTTP request
7f8b015 
handle promise rejection on send xhr analytics
@Yuvalke Yuvalke requested a review from a team November 12, 2020 13:42
@Yuvalke Yuvalke self-assigned this Nov 12, 2020
OrenMe
OrenMe approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@OrenMe OrenMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please change the error logging to warn as you suggested in internal ticket

@Yuvalke Yuvalke merged commit 426e5f8 into master Nov 25, 2020
@Yuvalke Yuvalke deleted the FEC-10635 branch November 25, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@Yuvalke Yuvalke

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yuvalke @OrenMe