Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-8975): QoS Kava Enhancements - leftovers #36

Merged
merged 5 commits into from
Jun 20, 2019
Merged

feat(FEC-8975): QoS Kava Enhancements - leftovers #36

merged 5 commits into from
Jun 20, 2019
+108 −4

Conversation

RoyBregman
Copy link
Contributor

adding networkConnectionType + restoring playerJSLoadTime unit test

@RoyBregman RoyBregman requested review from OrenMe and yairans June 18, 2019 12:25
OrenMe
OrenMe suggested changes Jun 18, 2019
View reviewed changes
src/kava.js Outdated Show resolved Hide resolved
OrenMe
OrenMe suggested changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@OrenMe OrenMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and please check flow and tests, they are failing

OrenMe
OrenMe suggested changes Jun 19, 2019
View reviewed changes
src/kava-event-model.js Outdated
@@ -46,6 +46,10 @@ export const KavaEventModel: {[event: string]: KavaEvent} = {
eventModel.targetBuffer = model.getTargetBuffer();
}

if (model.networkConnectionType != '') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (model.networkConnectionType != '') {
if (model.networkConnectionType() !== '') {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also see that model.getDroppedFramesRatio() doesn't have explicit type check, please always use explicit equality checks if (model.getDroppedFramesRatio() !== null) {
same for getDroppedFramesRatio check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand why. first of all I control the data in the of the networkConnectionType in the model so i don't expect it to be undefined or null and anyway undefined != '' is equal to undefined !==''

test/src/kava.spec.js
@@ -432,6 +477,8 @@ describe('KavaPlugin', function() {
});

it('should send VIEW event', done => {
sandbox.stub(window.navigator.connection, 'effectiveType').value('2g');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are missing tests for conditional data, what if connection doesn't exist?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you want me to add a test and force connection to be undefined?

@RoyBregman RoyBregman merged commit e10ab36 into master Jun 20, 2019
DanilMolchanovKaltura pushed a commit that referenced this pull request Nov 28, 2024
@lianbenjamin
feat(FEC-13530): change flavors terminology (#36)
1aab59e 
### Description of the Changes

change flavors terminology.

Solves FEC-13530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RoyBregman @OrenMe