fix(FEC-13783): Kava - Application Events - Fixes #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # test/e2e/kava-event-model.spec.js
…into FEC-13783 # Conflicts: # test/e2e/kava-event-model.spec.js
SivanA-Kaltura
requested changes
Mar 24, 2024
| @@ -326,6 +326,7 @@ class Kava extends BasePlugin { | |||
| this.eventManager.listen(this.player, this.player.Event.Core.MUTE_CHANGE, () => this._updateSoundModeInModel()); | |||
| this.eventManager.listen(this.player, this.player.Event.Core.ENTER_FULLSCREEN, () => this._onFullScreenChanged(ScreenMode.FULLSCREEN)); | |||
| this.eventManager.listen(this.player, this.player.Event.Core.EXIT_FULLSCREEN, () => this._onFullScreenChanged(ScreenMode.NOT_IN_FULLSCREEN)); | |||
| this.eventManager.listen(this.player, this.player.Event.REGISTERED_PLUGINS_LIST_EVENT, (e) => this._onRegisteredPluginsListChange(e.payload)); | |||
There was a problem hiding this comment.
the event fires when the active plugins list is updated ?
maybe it should be called PLUGIN_LIST_UPDATED then ?
There was a problem hiding this comment.
The main goal of this event is not notifying of plugins list change but just to expose the plugins list (on player load)
But anyway the kaltura pr was already merged
If it is critical I can open separate pr for this in kaltura player
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Application Events - Fixes
Resolves FEC-13783, FEC-13690
Related PRS:
kaltura/playkit-js-transcript#181
kaltura/playkit-js-dual-screen#132
Related Ticket: FEC-13691