Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FEC-11971): when in PiP mode user is considered not engaged #115

Merged
merged 5 commits into from
Feb 20, 2022

Conversation

lianbenjamin
Copy link
Contributor

Description of the Changes

the issue:
when in pip mode and switching tabs, user is not considered as "engaged" in realtime dashboard analytics.

root cause:
realtime analytics dashboard is considering "user engagement" when playback is unmuted and tab is focused. there are another 2 scenarios but they include fullscreen mode, which is irrelevant in case of pip mode.
when switching to another tab, kava plugin is sending view event with tabMode=notFocused even when in pip mode. hence, the realtime graph is showing that the user is not engaged.

solution:
kava plugin will report tabMode=focused in case we are in pip mode.
Note- changed also viewabilityMode to "in view" in case we are in pip mode. up until now, the viewabilityMode was "not in view" even when entering pip.

Solves FEC-11971

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@lianbenjamin lianbenjamin requested a review from yairans February 16, 2022 14:12
Copy link
Contributor

@yairans yairans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lianbenjamin LGTM. please add unit tests.

@lianbenjamin lianbenjamin merged commit 645f9a6 into master Feb 20, 2022
@lianbenjamin lianbenjamin deleted the FEC-11971-pip-user-engagement branch February 20, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants