feat(FEC-10615): support sending Kava beacons as POST #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-ziv
reviewed
Oct 29, 2020
| @@ -206,7 +207,7 @@ class Kava extends BasePlugin { | |||
| */ | |||
| sendAnalytics(model: Object): Promise<*> { | |||
| return new Promise((resolve, reject) => { | |||
| OVPAnalyticsService.trackEvent(this.config.serviceUrl, model) | |||
| OVPAnalyticsService.trackEvent(this.config.serviceUrl, model, this.config.requestMethod) | |||
There was a problem hiding this comment.
@yairans does the service is case sensitive?
There was a problem hiding this comment.
I would suggest to add toUpper... and not to force it.
Seems reasonable to pass also get/post.
OrenMe
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
add
requestMethodconfig (GETby default) and send it toOVPAnalyticsService.trackEventDepends on kaltura/playkit-js-providers#125
Solves FEC-10615
CheckLists