Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-9652): report playbackSpeed and captionsLanguage in all events #66

Merged
merged 4 commits into from
Mar 1, 2020
Merged

feat(FEC-9652): report playbackSpeed and captionsLanguage in all events #66

merged 4 commits into from
Mar 1, 2020

Conversation

RoyBregman
Copy link
Contributor

@RoyBregman RoyBregman commented Feb 24, 2020 •
edited
Loading

Description of the Changes

  • playbackSpeed and caption have been moved to common (for all events)
  • added check to send the proprty only if captions exist
  • removed captionLanguage property from VIEW
  • Changed unit tests to support the change
  • Docs changed accordingly

Solves FEC-9652

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@RoyBregman RoyBregman requested review from OrenMe and yairans February 24, 2020 16:32
@RoyBregman RoyBregman merged commit 40b8250 into master Mar 1, 2020
@RoyBregman RoyBregman deleted the FEC-9652-speed-caption-to-common branch March 4, 2020 13:48
DanilMolchanovKaltura pushed a commit that referenced this pull request Nov 28, 2024
@SivanA-Kaltura
fix: filter out flavors with height 0 (#66)
a810c34 
### Description of the Changes

Filter out flavors with height 0 to not show captions as sources

### CheckLists

- [ ] changes have been done against master branch, and PR does not
conflict
- [ ] new unit / functional tests have been added (whenever applicable)
- [ ] test are passing in local environment
- [ ] Travis tests are passing (or test results are not worse than on
master branch :))
- [ ] Docs have been updated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RoyBregman @OrenMe