Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-9345): send view event on first play #61

Merged
merged 3 commits into from
Nov 28, 2019
Merged

feat(FEC-9345): send view event on first play #61

merged 3 commits into from
Nov 28, 2019

Conversation

RoyBregman
Copy link
Contributor

@RoyBregman RoyBregman commented Nov 27, 2019 •
edited
Loading

Description of the Changes

  • Added view event call to kava on first play
  • updated docs

solves FEC-9345

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

OrenMe
OrenMe suggested changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@OrenMe OrenMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add test

@RoyBregman RoyBregman merged commit 53e16be into master Nov 28, 2019
@RoyBregman RoyBregman deleted the FEC-9345-send-view-on-first-play branch November 28, 2019 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

@Yuvalke Yuvalke Awaiting requested review from Yuvalke

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RoyBregman @OrenMe