Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-9220): QoE tidbits #51

Merged
merged 6 commits into from
Nov 8, 2019
Merged

feat(FEC-9220): QoE tidbits #51

merged 6 commits into from
Nov 8, 2019

Conversation

RoyBregman
Copy link
Contributor

@RoyBregman RoyBregman commented Nov 4, 2019 •
edited
Loading

Description of the Changes

changing soundMode, tabMode and networkConnectionType - to be updated in model upon event change

Solves FEC-9220

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@RoyBregman RoyBregman marked this pull request as ready for review November 5, 2019 07:37
yairans
yairans suggested changes Nov 7, 2019
View reviewed changes
src/kava.js Outdated Show resolved Hide resolved
src/kava.js Outdated Show resolved Hide resolved
src/kava.js Outdated Show resolved Hide resolved
src/kava.js Outdated Show resolved Hide resolved
src/kava.js Outdated Show resolved Hide resolved
src/kava.js Outdated Show resolved Hide resolved
src/kava.js Outdated Show resolved Hide resolved
yairans
yairans suggested changes Nov 7, 2019
View reviewed changes
src/kava.js Outdated
}

if (hiddenAttr && visibilityChangeEventName) {
document.addEventListener(visibilityChangeEventName, () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use eventManager

@RoyBregman RoyBregman merged commit 36b952c into master Nov 8, 2019
@RoyBregman RoyBregman deleted the FEC-9220-QoE-tidbits branch November 8, 2019 10:21
DanilMolchanovKaltura pushed a commit that referenced this pull request Nov 28, 2024
@JonathanTGold
feat(RE-REVERT-FEC-13730): Download plugin, ignore system attachments (…
c1cbb26 
…#51)

###  Description of the Changes

Download plugin, ignore system attachments

Resolves [FEC-13730](https://kaltura.atlassian.net/browse/FEC-13730)

[FEC-13730]:
https://kaltura.atlassian.net/browse/FEC-13730?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yairans yairans yairans approved these changes

@OrenMe OrenMe Awaiting requested review from OrenMe

@Yuvalke Yuvalke Awaiting requested review from Yuvalke

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RoyBregman @yairans