Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-9343): add playback rate change event #50

Merged
merged 2 commits into from
Oct 7, 2019
Merged

feat(FEC-9343): add playback rate change event #50

merged 2 commits into from
Oct 7, 2019

Conversation

RoyBregman
Copy link
Contributor

@RoyBregman RoyBregman commented Oct 6, 2019 •
edited
Loading

Description of the Changes

Added new event 41 to report speed playback change

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@RoyBregman RoyBregman requested review from OrenMe and yairans October 6, 2019 20:05
@RoyBregman RoyBregman merged commit 79a93cc into master Oct 7, 2019
@RoyBregman RoyBregman deleted the FEC-9343-playback-rate branch October 7, 2019 05:20
DanilMolchanovKaltura pushed a commit that referenced this pull request Nov 28, 2024
@Tzipi-kaltura
fix(FEC-13868): Player v7 | Download | Default language is being dupl…
c1fcd65 
…icated on kms. (#50)

Issue:
The first captions is being duplicated in the caption list

Root cause:
If there is no default caption (on the entry) player set the first captions form the list as the default and displays it on the download dialog, since caption.isDefault returns false we display this captions also in the hide captions so when user click on "More captions" he will see the first caption again.

Solution:
Check if caption is not the default by the user and it's not the default by the player.

Solves FEC-13868
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RoyBregman @OrenMe