fix(FEC-9237): add app protocol for kava plugin #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add protocol for plugin for Samsung Smart TV
OrenMe
suggested changes
Jul 21, 2019
src/kava.js
Outdated
| @@ -76,7 +77,7 @@ class Kava extends BasePlugin { | |||
| bufferTimeSum: 0.0, | |||
| playTimeSum: 0.0 | |||
| }); | |||
|
|
|||
| this._appProtocol = /^(https?:)/i.test(document.location.protocol) ? document.location.protocol : 'https:'; | |||
There was a problem hiding this comment.
if this is becoming a repeating pattern let's add this as a util
getProtocol(defaultProtocol: string): string {
return /^(https?:)/i.test(document.location.protocol) ? document.location.protocol : defaultProtocol;
}There was a problem hiding this comment.
we have player utils class for such things
OrenMe
approved these changes
Jul 21, 2019
OrenMe
approved these changes
Jul 21, 2019
DanilMolchanovKaltura
pushed a commit
that referenced
this pull request
Nov 28, 2024
#43) ### Description of the Changes Adjusting Events (used by kava analytics) #### Solves FEC-13717 #### Related PR: #156 --------- Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
add protocol for plugin for Samsung Smart TV bug
CheckLists