feat(FEC-9224): refactoring networkConnectionOverhead to use PerformanceObserver #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrenMe
suggested changes
Jul 18, 2019
Co-Authored-By: Oren Me <[email protected]>
OrenMe
suggested changes
Jul 18, 2019
src/kava.js
Outdated
| @@ -117,6 +135,22 @@ class Kava extends BasePlugin { | |||
| playTimeSum: 0.0, | |||
| sessionStartTime: null | |||
| }); | |||
| this._performanceObserver.disconnect(); | |||
There was a problem hiding this comment.
to avoid of the duplicate code maybe put common reset and destroy actions in _reset method and call it from both destroy and reset.
_reset(): void {
this._timer.destroy();
this._rateHandler.destroy();
this._performanceObserver.disconnect();
this._performanceEntries = [];
this._pendingFragLoadedEvents = [];
}…her data that comes from the frag_loaded
OrenMe
approved these changes
Jul 19, 2019
DanilMolchanovKaltura
pushed a commit
that referenced
this pull request
Nov 28, 2024
… update (#42) Adding "aria-hidden" to icon's elements Resolves ADA-490
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the networkConnectionOverhead to use PerformanceObserver due to buffer limitations of performance.getEntriesByType