Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEC-8975 QoS data enhancement #35

Merged
merged 20 commits into from
Jun 16, 2019
Merged

FEC-8975 QoS data enhancement #35

merged 20 commits into from
Jun 16, 2019

Conversation

RoyBregman
Copy link
Contributor

Description of the Changes

Adding Bandwidth, segment download time, soundMode and tabMode to 99 view report

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@RoyBregman RoyBregman requested review from OrenMe and yairans May 15, 2019 19:13
OrenMe
OrenMe suggested changes May 16, 2019
View reviewed changes
src/kava.js Outdated Show resolved Hide resolved
src/kava.js Outdated Show resolved Hide resolved
src/kava.js Outdated Show resolved Hide resolved
itaykinnrot
itaykinnrot reviewed May 17, 2019
View reviewed changes
src/kava.js Outdated Show resolved Hide resolved
@itaykinnrot
Copy link

General note - Unit tests are must here...

@kaltura-hooks
Copy link

Hi @RoyBregman,
Thank you for contributing this pull request!
Please sign the Kaltura CLA so we can review and merge your contribution.
Learn more at http://bit.ly/KalturaContrib

OrenMe
OrenMe suggested changes Jun 15, 2019
View reviewed changes
src/kava-event-model.js Outdated Show resolved Hide resolved
src/kava.js Outdated Show resolved Hide resolved
OrenMe
OrenMe suggested changes Jun 16, 2019
View reviewed changes
src/kava.js Outdated Show resolved Hide resolved
@OrenMe OrenMe merged commit e1e4eda into master Jun 16, 2019
@OrenMe OrenMe deleted the FEC-8975-QoS-Data-enhancement-for-KAVA branch June 16, 2019 19:20
DanilMolchanovKaltura pushed a commit that referenced this pull request Nov 28, 2024
@lianbenjamin
feat(FEC-13362): add events for kava (#35)
6acbd10 
### Description of the Changes

add new event for kava- when downloading an item.

Solves FEC-13362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itaykinnrot itaykinnrot itaykinnrot left review comments

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RoyBregman @itaykinnrot @kaltura-hooks @OrenMe