Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-8803): add 'canPlay' param to the 'play' event #31

Merged
merged 2 commits into from
Feb 27, 2019
Merged

feat(FEC-8803): add 'canPlay' param to the 'play' event #31

merged 2 commits into from
Feb 27, 2019

Conversation

odedhutzler
Copy link
Contributor

add canPlay param to the play event kava sends.
Also, changed the way we measure joinTime.
Untill now it was measured from the play event sent from the video element until the playing event.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@odedhutzler
add canPlay param to the play event kava sends
ce9c361 
Also, changed the way we measure joinTime.
Untill now it was measured from the `play` event sent from the video element until the `playing` event.
@odedhutzler odedhutzler self-assigned this Feb 12, 2019
@odedhutzler odedhutzler requested a review from a team February 12, 2019 08:55
@odedhutzler odedhutzler changed the title feat(FEC-8803): add canPlay param to the play event kava sends feat(FEC-8803): add canPlay param to the play event Feb 17, 2019
@yairans yairans changed the title feat(FEC-8803): add canPlay param to the play event feat(FEC-8803): add 'canPlay' param to the 'play' event Feb 20, 2019
OrenMe
OrenMe suggested changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@OrenMe OrenMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix tests

OrenMe
OrenMe suggested changes Feb 27, 2019
View reviewed changes
src/kava.js Outdated Show resolved Hide resolved
@odedhutzler odedhutzler merged commit 6b1eab7 into master Feb 27, 2019
@odedhutzler odedhutzler deleted the FEC-8803 branch February 27, 2019 12:44
@odedhutzler odedhutzler mentioned this pull request Mar 5, 2019
Merged
5 tasks
odedhutzler added a commit that referenced this pull request Mar 5, 2019
@odedhutzler
revert: new joinTime calculation (#31) (#32)
10dcfce 
* flag is not needed as playback start is sent once for each media

* revert the joinTimeCalculattion
DanilMolchanovKaltura pushed a commit that referenced this pull request Nov 28, 2024
@Tzipi-kaltura
fix(SUP-39294): Page refreshes after clicking on player buttons (#31)
27ea069 
issue:
When embed player in a form element and click on the plugin button, the page refreshes.

solution:
add type=button on the plugin button

solves SUP-39294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@odedhutzler odedhutzler

Labels
Priority: Medium
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odedhutzler @OrenMe