fix(FEC-8606): "Play 100%" event is not sent on IE11 Win7 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 29, 2019 11:56
|
Hi @shalommeoded, |
OrenMe
approved these changes
Jan 29, 2019
DanilMolchanovKaltura
pushed a commit
that referenced
this pull request
Nov 28, 2024
Description of the Changes the issue: when loading a YT entry and clicking the download icon button, there is a source to download (with image icon), although there are no flavors for youtube entries. solution: render download item for image only if imageUrl has a value; render sources (default and flavors) only if array of flavors is not empty - it is possible to have a youtube entry, which has no flavors, but has captions which we would like to allow downloading. Solves FEC-13455
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
const percent = this.player.currentTime / this.player.duration, returened a number above 1 on IE 11, therefore, never entred, theif (!this._timePercentEvent.PLAY_REACHED_100 && percent === 1)condition.The fix:
toFixedfunction.parseFloatfunction.