Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-8296): add applicationVersion and playbackContext #3

Merged
merged 1 commit into from
Jun 11, 2018
Merged

feat(FEC-8296): add applicationVersion and playbackContext #3

merged 1 commit into from
Jun 11, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Jun 11, 2018

Description of the Changes

Add configurable values of applicationVersion and playbackContext

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Jun 11, 2018
@dan-ziv dan-ziv requested a review from OrenMe June 11, 2018 08:02
@dan-ziv dan-ziv changed the title fix: add applicationVersion and playbackContext feat(FEC-8296): add applicationVersion and playbackContext Jun 11, 2018
@dan-ziv dan-ziv merged commit 0252c59 into master Jun 11, 2018
@dan-ziv dan-ziv deleted the appVersion-playabckContext branch June 11, 2018 08:16
JonathanTGold added a commit that referenced this pull request Mar 18, 2024
@JonathanTGold
feat(FEC-13771): Application events analytics reporting to kava - Phase
ac2234e 
#3 (#159)

feat(FEC-13771): Application events analytics reporting to kava Phase #3

---------

Co-authored-by: JonathanTGold <jonathan.gold@[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-ziv @OrenMe