Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-8337): add captions and audio language to view events #29

Merged
merged 3 commits into from
Jan 24, 2019
Merged

feat(FEC-8337): add captions and audio language to view events #29

merged 3 commits into from
Jan 24, 2019

Conversation

odedhutzler
Copy link
Contributor

@odedhutzler odedhutzler commented Jan 24, 2019 •
edited
Loading

Description of the Changes

added the two params to the model sent to the server:

audioLanguage: model.getLanguage()
captionsLanguage: model.getCaption()

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@odedhutzler odedhutzler self-assigned this Jan 24, 2019
@odedhutzler odedhutzler requested a review from a team January 24, 2019 13:38
@odedhutzler odedhutzler merged commit 420d690 into master Jan 24, 2019
@odedhutzler odedhutzler deleted the FEC-8337 branch January 24, 2019 13:53
DanilMolchanovKaltura pushed a commit that referenced this pull request Nov 28, 2024
@lianbenjamin
fix(FEC-13456): add cypress tests (#29)
78e7eeb 
### Description of the Changes

add cypress tests.

Solves FEC-13456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@odedhutzler odedhutzler

Labels
Priority: Medium Type: Feature
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odedhutzler @OrenMe