fix(FEC-8657): add buffer start/end events #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrenMe
suggested changes
Nov 14, 2018
There was a problem hiding this comment.
the test is more like - when event of buffer start arrives then see that _sendAnalytics is called with the event and same for buffer end.
I don't think the tests that were just added are useful.
I see 3 tests:
- When buffer start event arrives see we call
_sendAnalyticswith buffer start - When buffer end event arrives see we call
_sendAnalyticswith buffer end only if previous state was buffer start - When buffer end event arrives see we don't call
_sendAnalyticswith buffer end if previous state wasn't start(which should be impossible)
OrenMe
approved these changes
Nov 14, 2018
DanilMolchanovKaltura
pushed a commit
that referenced
this pull request
Nov 28, 2024
### Description of the Changes **the issue:** in image entry case, there are no flavors and no captions, but there might be attachments. in case there are no attachments as well, the request to BE to get the downloadUrls is failing; therefore, the download icon is absent. **solution:** make the multiRequest to get the download urls, only if at least 1 of the arrays (flavors/captions/attachments) is not empty. Solves FEC-13452
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Need to add BUFFER_START (45) & BUFFER_END (46) events.
Send only common params.
CheckLists