Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-8629): add hooks to Kava to enable analytics event tampering and sending custom events #26

Merged
merged 3 commits into from
Nov 1, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Nov 1, 2018

Description of the Changes

Add tamperAnalyticsHandler config option and expose sendAnalytics API.
Read more from the docs.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv requested a review from OrenMe November 1, 2018 14:46
@dan-ziv dan-ziv merged commit fdcc08d into master Nov 1, 2018
@dan-ziv dan-ziv deleted the FEC-8629 branch November 1, 2018 15:20
DanilMolchanovKaltura pushed a commit that referenced this pull request Nov 28, 2024
### Description of the Changes

this PR is an improvement for download plugin:
- allow downloading flavors
- allow downloading captions
- allow downloading attachments

3 new configurations available:
- `displayFlavors` - default is `true`; if set to `false` then only the default/configures source will be available for download
- `displayCaptions` - default is `true`; if set to `false`, captions will not be available for download
- `displayAttachments` - default is `true`; if set to `false`, attachments will not be available for download

Solves FEC-13341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants