Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8414): referrer should not be base64 encoded #20

Merged
merged 1 commit into from
Jul 16, 2018
Merged

fix(FEC-8414): referrer should not be base64 encoded #20

merged 1 commit into from
Jul 16, 2018

Conversation

OrenMe
Copy link
Contributor

@OrenMe OrenMe commented Jul 16, 2018

Description of the Changes

Change referrer string to only be URI encoded and not base64 encoded

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@OrenMe OrenMe added the bug label Jul 16, 2018
@OrenMe OrenMe self-assigned this Jul 16, 2018
@OrenMe OrenMe requested a review from dan-ziv July 16, 2018 13:12
@dan-ziv dan-ziv merged commit 5d52ca9 into master Jul 16, 2018
@dan-ziv dan-ziv deleted the FEC-8414 branch July 16, 2018 13:19
DanilMolchanovKaltura pushed a commit that referenced this pull request Nov 28, 2024
@github-actions @lianbenjamin
Upgrade Kaltura dependencies (automated) (#20)
3478306 
Co-authored-by: lianbenjamin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-ziv dan-ziv dan-ziv approved these changes

Assignees

@OrenMe OrenMe

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OrenMe @dan-ziv