Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8354): When selecting Audio language and refresh the page, the display language returns to default (but actual audio proper) #18

Merged
merged 6 commits into from
Jun 28, 2018
Merged

fix(FEC-8354): When selecting Audio language and refresh the page, the display language returns to default (but actual audio proper) #18

merged 6 commits into from
Jun 28, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Jun 28, 2018

Description of the Changes

Please add a detailed description of the change, weather it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv requested a review from OrenMe June 28, 2018 10:03
OrenMe
OrenMe suggested changes Jun 28, 2018
View reviewed changes
Copy link
Contributor

@OrenMe OrenMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dan-ziv please handle failing test

@dan-ziv
Copy link
Contributor Author

dan-ziv commented Jun 28, 2018

@OrenMe done

OrenMe
OrenMe previously requested changes Jun 28, 2018
View reviewed changes
Copy link
Contributor

@OrenMe OrenMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dan-ziv please check new test failing

@dan-ziv dan-ziv merged commit eb70a1c into master Jun 28, 2018
@dan-ziv dan-ziv deleted the FEC-8354 branch June 28, 2018 13:27
DanilMolchanovKaltura pushed a commit that referenced this pull request Nov 28, 2024
@Tzipi-kaltura
fix(FEC-13295) Download plugin - Accessibility - Need to change the d…
f545f6f 
…ownload button lable in the download overlay (#18)

screen reader reads the file name in the download button,
change it to “Click to download the video”

solves FEC-13295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-ziv @OrenMe