fix(SUP-42252): Actual view time for clips is not correct #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tzipi-kaltura
requested review from
JonathanTGold,
SivanA-Kaltura,
semarche-kaltura and
lianbenjamin
SivanA-Kaltura
requested changes
May 27, 2024
SivanA-Kaltura
requested changes
May 27, 2024
src/kava.ts
Outdated
| } | ||
| return 0; | ||
| } | ||
| return this._isFirstPlaying ? this.player.currentTime! || this.player.sources.startTime || 0 : this.player.currentTime!; | ||
| if (this.player.sources.seekFrom && currentTime) { |
There was a problem hiding this comment.
well, i dont like the structure of the function, but i dont want to refactor the whole thing now.
i think this would be more readable
let currentTime = this.player.currentTime;
if (typeof this.player.sources.seekFrom === "number" && currentTime) {
currentTime += this.player.sources.seekFrom;
}
and in the use of currentTime in the lines above, keep the existing syntax of this.player.currentTime.
SivanA-Kaltura
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
Issue:
When playing only part of video by using the seekFrom the duration and currentTime is calculated according to the new times. so the position value (sent to analytics) is calculated from start time =0 (even that this is not 0 in the fully video).
Solution:
If seekFrom is defined, calculate the currentTime with the seekFrom value.
Solves SUP-42252
CheckLists