Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FEC-13362): add new events #154

Merged
merged 2 commits into from
Dec 11, 2023
Merged

feat(FEC-13362): add new events #154

merged 2 commits into from
Dec 11, 2023

Conversation

lianbenjamin
Copy link
Contributor

Description of the Changes

add new events:

  • enter fullscreen
  • exit fullscreen
  • info clicked (info)
  • download clicked (downloads)
  • report clicked (moderation)
  • report submitted (moderation)

dependent on PRs:
kaltura/playkit-js-info#86
kaltura/playkit-js-downloads#35
kaltura/playkit-js-moderation#67

Solves FEC-13362

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@semarche-kaltura
Copy link
Contributor

@lianbenjamin could you compare bundle size before and after current PR (wanna know if bundle includes only event string from plugins or entire plugins code)

SivanA-Kaltura
SivanA-Kaltura requested changes Dec 10, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@lianbenjamin
Copy link
Contributor Author

lianbenjamin commented Dec 10, 2023 •
edited
Loading

@semarche-kaltura
after my changes vs before my changes- playkit-kava.js was increased by 2KB and playkit-kava.js.map was increased by 4KB.

@lianbenjamin lianbenjamin merged commit 6677f44 into master Dec 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SivanA-Kaltura SivanA-Kaltura SivanA-Kaltura approved these changes

@semarche-kaltura semarche-kaltura semarche-kaltura approved these changes

@MosheMaorKaltura MosheMaorKaltura Awaiting requested review from MosheMaorKaltura

@JonathanTGold JonathanTGold Awaiting requested review from JonathanTGold

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lianbenjamin @semarche-kaltura @SivanA-Kaltura