Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-12613): Image Entry - Kava Analytics Events #135

Merged
merged 3 commits into from
Feb 9, 2023
Merged

fix(FEC-12613): Image Entry - Kava Analytics Events #135

merged 3 commits into from
Feb 9, 2023

Conversation

JonathanTGold
Copy link
Contributor

@JonathanTGold JonathanTGold commented Feb 6, 2023 •
edited
Loading

Description of the Changes

  • Add applicationType of 'img'
  • Cancel VIEW event (triggered every 10 seconds ) from be reported on Non-Durational image

solves FEC-12613

related pr: kaltura/kaltura-player-js#604

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@JonathanTGold JonathanTGold mentioned this pull request Feb 6, 2023
Merged
5 tasks
@JonathanTGold JonathanTGold merged commit a0a3c27 into master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semarche-kaltura semarche-kaltura semarche-kaltura approved these changes

@giladna giladna Awaiting requested review from giladna

@lianbenjamin lianbenjamin Awaiting requested review from lianbenjamin

@SivanA-Kaltura SivanA-Kaltura Awaiting requested review from SivanA-Kaltura

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonathanTGold @semarche-kaltura