Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-12923): Add missing applications data on kava beacons & config #134

Merged
merged 4 commits into from
Feb 5, 2023

Conversation

giladna
Copy link
Contributor

@giladna giladna commented Feb 1, 2023

Add:

  • application?: string,
  • kalturaApplicationVersion?: string,
  • kalturaApplication?: string,

FEC-12923

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

  application?: string,
  kalturaApplicationVersion?: string,
  kalturaApplication?: string,
add mapping for kalturaApplication param

const KalturaApplication: ApplicationType = {
  KMC: '0',
  KMS: '1',
  KAF: '2',
  PITCH: '3',
  KMS_GO: '4',
  WEBCASTING: '5',
  PERSONAL_CAPTURE: '6',
  KME: '7',
  KME_MOBILE_APP: '8',
  PATH: '9',
  LECTURE_CAPTURE: '10',
  EP: '11',
  CHAT_AND_COLLABORATION: '12',
  ANALYTICS: '13',
  EXPRESS_CAPTURE: '14',
  KPF: '15',
  KAF_GO: '16',
  SITES: '17',
  STUDIO: '18'
};
@giladna giladna merged commit 1c76ade into master Feb 5, 2023
@giladna giladna deleted the FEC-12923 branch February 5, 2023 11:05
@JonathanTGold JonathanTGold self-requested a review February 5, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants