Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8306): No 'Play request' events are sent in web #10

Merged
merged 2 commits into from
Jun 13, 2018
Merged

fix(FEC-8306): No 'Play request' events are sent in web #10

merged 2 commits into from
Jun 13, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Jun 13, 2018 •
edited
Loading

Description of the Changes

remove ready and initial tracks on TRACKS_CHANGE event.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Jun 13, 2018
@dan-ziv dan-ziv requested a review from OrenMe June 13, 2018 08:55
OrenMe
OrenMe approved these changes Jun 13, 2018
View reviewed changes
Copy link
Contributor

@OrenMe OrenMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dan-ziv please fix build

@dan-ziv dan-ziv merged commit a78647f into master Jun 13, 2018
@dan-ziv dan-ziv deleted the FEC-8306 branch June 13, 2018 10:20
DanilMolchanovKaltura pushed a commit that referenced this pull request Nov 28, 2024
@semarche-kaltura
fix(FEC-13216): update dependencies (#10)
6a4d242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-ziv @OrenMe