fix(FEC-8415): kava should report bitrate in kbps (#21)

convert bps to kbps unit for reporting bitrate.
kaltura · Jul 18, 2018 · fc52347 · fc52347
1 parent 5d52ca9
commit fc52347
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/src/kava.js b/src/kava.js
@@ -6,6 +6,13 @@ import {KavaRateHandler} from './kava-rate-handler';
 import {KavaTimer} from './kava-timer';
 import {KavaModel} from './kava-model';
 
+/**
+ * The bps to kbps divsor
+ * @type {number}
+ * @const
+ */
+const DIVIDER: number = 1024;
+
 /**
  * KAVA (Kaltura Advanced Analytics) plugin class.
  * @constructor
@@ -174,7 +181,7 @@ class Kava extends BasePlugin {
   _getRates(): Array<number> {
     const rates = [];
     const videoTracks = this.player.getTracks(this.player.Track.VIDEO);
-    videoTracks.forEach(videoTrack => rates.push(videoTrack.bandwidth));
+    videoTracks.forEach(videoTrack => rates.push(videoTrack.bandwidth / DIVIDER));
     return rates;
   }
 
@@ -183,7 +190,7 @@ class Kava extends BasePlugin {
     const activeTracks = this.player.getActiveTracks();
     this._rateHandler.setRates(rates);
     if (activeTracks.video) {
-      this._rateHandler.setCurrent(activeTracks.video.bandwidth);
+      this._rateHandler.setCurrent(activeTracks.video.bandwidth / DIVIDER);
     }
     if (activeTracks.audio) {
       this._model.updateModel({language: activeTracks.audio.language});
@@ -274,7 +281,7 @@ class Kava extends BasePlugin {
 
   _onVideoTrackChanged(event: FakeEvent): void {
     const videoTrack = event.payload.selectedVideoTrack;
-    this._rateHandler.setCurrent(videoTrack.bandwidth);
+    this._rateHandler.setCurrent(videoTrack.bandwidth / DIVIDER);
     if (this.player.isAdaptiveBitrateEnabled()) {
       this._sendAnalytics(KavaEventModel.FLAVOR_SWITCH);
     } else {

diff --git a/test/src/kava.spec.js b/test/src/kava.spec.js
@@ -332,7 +332,7 @@ describe('KavaPlugin', function() {
       sandbox.stub(OVPAnalyticsService, 'trackEvent').callsFake((serviceUrl, params) => {
         if (params.eventType !== KavaEventModel.SOURCE_SELECTED.index) return;
         validateCommonParams(params, KavaEventModel.SOURCE_SELECTED.index);
-        params.actualBitrate.should.equal(480256);
+        params.actualBitrate.should.equal(480256 / 1024);
         done();
         return new RequestBuilder();
       });
@@ -348,7 +348,7 @@ describe('KavaPlugin', function() {
       sandbox.stub(OVPAnalyticsService, 'trackEvent').callsFake((serviceUrl, params) => {
         if (params.eventType !== KavaEventModel.FLAVOR_SWITCH.index) return;
         validateCommonParams(params, KavaEventModel.FLAVOR_SWITCH.index);
-        params.actualBitrate.should.equal(480256);
+        params.actualBitrate.should.equal(480256 / 1024);
         done();
         return new RequestBuilder();
       });