feat(FEC-9344): adding playbackSpeed to view event (#60)

kaltura · Nov 28, 2019 · 8eec2d9 · 8eec2d9
1 parent 498576b
commit 8eec2d9
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/docs/kava-events.md b/docs/kava-events.md
@@ -46,6 +46,7 @@ Here we will see some explanation about each event. When does it sent and what p
   - [`networkConnectionType`](./kava-parameters.md#networkConnectionType)
   - [`networkConnectionOverhead`](./kava-parameters.md#networkConnectionOverhead)
   - [`flavorParamsId`](./kava-parameters.md#flavorParamsId)
+  - [`playbackSpeed`](./kava-parameters.md#playbackSpeed)
 - Sent every 10 second of active playback (when player is paused, view timer should be paused/stopped).
 - 30 seconds without VIEW event will reset KAVA session, so all the VIEW [specific parameters](#endSessionResetParams) should be reset also.
 - Server may notify Kava (via response field ["viewEventsEnabled" = false](#serverResponse)) to shut down VIEW events. When it happens, VIEW events should be blocked from sending until server decides to enable VIEW events again.
@@ -56,7 +57,7 @@ Here we will see some explanation about each event. When does it sent and what p
 
 - Event ID: `1`
 - Player Event: `SOURCE_SELECTED`
-- Event Parameters: 
+- Event Parameters:
   - [`COMMON_PARAMS`](./kava-parameters.md#common_params)
   - [`playerJSLoadTime`](./kava-parameters.md#playerJSLoadTime)
 

diff --git a/src/kava-event-model.js b/src/kava-event-model.js
@@ -23,7 +23,8 @@ export const KavaEventModel: {[event: string]: KavaEvent} = {
         audioLanguage: model.getLanguage(),
         captionsLanguage: model.getCaption(),
         soundMode: model.getSoundMode(),
-        tabMode: model.getTabMode()
+        tabMode: model.getTabMode(),
+        playbackSpeed: model.getPlaybackSpeed()
       };
 
       if (!isNaN(model.getForwardBufferHealth())) {

diff --git a/test/src/kava-event-model.spec.js b/test/src/kava-event-model.spec.js
@@ -130,7 +130,8 @@ describe('KavaEventModel', () => {
       targetBuffer: fakeModel.getTargetBuffer(),
       networkConnectionType: fakeModel.getNetworkConnectionType(),
       networkConnectionOverhead: fakeModel.getNetworkConnectionOverhead(),
-      flavorParamsId: fakeModel.getFlavorParamsId()
+      flavorParamsId: fakeModel.getFlavorParamsId(),
+      playbackSpeed: fakeModel.getPlaybackSpeed()
     });
   });
 

diff --git a/test/src/kava.spec.js b/test/src/kava.spec.js
@@ -511,7 +511,8 @@ describe('KavaPlugin', function() {
               'soundMode',
               'tabMode',
               'networkConnectionType',
-              'userId'
+              'userId',
+              'playbackSpeed'
             );
             params.networkConnectionType.should.equal('2g');
             params.tabMode.should.equal(TabMode.TAB_FOCUSED);