Skip to content

Commit

Permalink
fix(SUP-37882): Events are not sent to GTM (#17)
Browse files Browse the repository at this point in the history
GTM is not activated when the string of the container id contains less than 7 characters.
(It doesn't have to be exactly 7)

solves SUP-37882
  • Loading branch information
Tzipi-kaltura authored Jun 18, 2023
1 parent c824aca commit 15ba984
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/run_canary_full_flow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
jobs:
canary-full-flow:
if: ${{ github.actor != 'PlaykitJs-Bot' }}
uses: kaltura/ovp-pipelines-pub/.github/workflows/player_cicd.yaml@v1.0.0
uses: kaltura/ovp-pipelines-pub/.github/workflows/player_cicd.yaml@uuid_wa
secrets:
PLAYER_CENTRAL_ACCOUNT_ID: ${{ secrets.PLAYER_CENTRAL_ACCOUNT_ID }}
PLAYER_SERVICES_ACCOUNT_ID: ${{ secrets.PLAYER_SERVICES_ACCOUNT_ID }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run_prod.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:

jobs:
prod:
uses: kaltura/ovp-pipelines-pub/.github/workflows/player_cicd.yaml@v1.0.0
uses: kaltura/ovp-pipelines-pub/.github/workflows/player_cicd.yaml@uuid_wa
secrets:
PLAYER_CENTRAL_ACCOUNT_ID: ${{ secrets.PLAYER_CENTRAL_ACCOUNT_ID }}
PLAYER_SERVICES_ACCOUNT_ID: ${{ secrets.PLAYER_SERVICES_ACCOUNT_ID }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/run_tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:

jobs:
running-tests:
uses: kaltura/ovp-pipelines-pub/.github/workflows/player_tests.yaml@v1.0.0
uses: kaltura/ovp-pipelines-pub/.github/workflows/player_tests.yaml@uuid_wa
with:
yarn-run-to-execute: 'build lint:check types:check test'
notification:
Expand Down
2 changes: 1 addition & 1 deletion src/google-tag-manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class GoogleTagManager extends BasePlugin<GoogleTagManagerConfig> {

constructor(name: string, player: KalturaPlayer, config?: GoogleTagManagerConfig) {
super(name, player, config);
if (this.config.containerId.match(/^GTM-[A-Z1-9]{7}$/)) {
if (this.config.containerId.match(/^GTM-[A-Z1-9]{2,}$/)) {
this.loadTag();
this.aggregatePlayerEvents();
this.initCustomEventsListeners();
Expand Down

0 comments on commit 15ba984

Please sign in to comment.