feat(FEC-8975): adding segment size in target buffer when exceeding maxmax #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrenMe
suggested changes
Jun 20, 2019
src/dash-adapter.js
Outdated
| const activeTrackId = activeTrack ? activeTrack.id : NaN; | ||
| let segmentLength = 0; | ||
| if (!isNaN(activeTrackId)) { | ||
| for (let i = 0; i < this._shaka.getManifest().periods.length; i++) { |
There was a problem hiding this comment.
you can store const periods = this._shaka.getManifest().periods; and it will make the rest of the access a lot less verbose.
OrenMe
suggested changes
Jun 20, 2019
src/dash-adapter.js
Outdated
| const activeTrackId = activeTrack ? activeTrack.id : NaN; | ||
| let segmentLength = 0; | ||
| if (!isNaN(activeTrackId)) { | ||
| for (let i = 0; i < this._shaka.getManifest().periods.length; i++) { |
There was a problem hiding this comment.
Suggested change
| for (let i = 0; i < this._shaka.getManifest().periods.length; i++) { | |
| const periods = this._shaka.getManifest().periods; | |
| for (let i = 0; i < .periods.length; i++) { |
src/dash-adapter.js
Outdated
| let segmentLength = 0; | ||
| if (!isNaN(activeTrackId)) { | ||
| for (let i = 0; i < this._shaka.getManifest().periods.length; i++) { | ||
| for (let j = 0; j < this._shaka.getManifest().periods[i].variants.length; j++) { |
There was a problem hiding this comment.
Suggested change
| for (let j = 0; j < this._shaka.getManifest().periods[i].variants.length; j++) { | |
| for (let j = 0; j < periods[i].variants.length; j++) { |
src/dash-adapter.js
Outdated
| if (!isNaN(activeTrackId)) { | ||
| for (let i = 0; i < this._shaka.getManifest().periods.length; i++) { | ||
| for (let j = 0; j < this._shaka.getManifest().periods[i].variants.length; j++) { | ||
| const variant = this._shaka.getManifest().periods[i].variants[j]; |
There was a problem hiding this comment.
Suggested change
| const variant = this._shaka.getManifest().periods[i].variants[j]; | |
| const variant = periods[i].variants[j]; |
OrenMe
approved these changes
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(FEC-8975): adding segment size in target buffer when exceeding maxmax