Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-8079): move src getter to base adapter #50

Merged
merged 2 commits into from
Mar 27, 2018
Merged

fix(FEC-8079): move src getter to base adapter #50

merged 2 commits into from
Mar 27, 2018

Conversation

dan-ziv
Copy link
Contributor

@dan-ziv dan-ziv commented Mar 26, 2018 •
edited
Loading

Description of the Changes

Move the src getter to the base adapter since they all have the same implementation now.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@dan-ziv dan-ziv self-assigned this Mar 26, 2018
odedhutzler
odedhutzler approved these changes Mar 26, 2018
View reviewed changes
Copy link
Contributor

@odedhutzler odedhutzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OrenMe
Copy link
Contributor

OrenMe commented Mar 27, 2018

@dan-ziv LGTM, please fix failing test

@dan-ziv dan-ziv merged commit 16dd32a into master Mar 27, 2018
@dan-ziv dan-ziv deleted the FEC-8079 branch March 27, 2018 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@odedhutzler odedhutzler odedhutzler approved these changes

@yairans yairans Awaiting requested review from yairans

Assignees

@dan-ziv dan-ziv

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dan-ziv @OrenMe @odedhutzler