Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: source type update #41

Merged
merged 2 commits into from
Jan 28, 2018
Merged

fix: source type update #41

merged 2 commits into from
Jan 28, 2018

Conversation

odedhutzler
Copy link
Contributor

@odedhutzler odedhutzler commented Jan 15, 2018 •
edited
Loading

Description of the Changes

Updated the source type of the media according to the new types in playkit-js

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@odedhutzler odedhutzler self-assigned this Jan 15, 2018
@dan-ziv dan-ziv merged commit 1360fdc into master Jan 28, 2018
@dan-ziv dan-ziv deleted the SourceTypeUpdate branch January 28, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans Awaiting requested review from yairans

@dan-ziv dan-ziv Awaiting requested review from dan-ziv

Assignees

@odedhutzler odedhutzler

Labels
Priority: Medium
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odedhutzler @OrenMe @dan-ziv