Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-12539): Shaka text displayer font size too small on TVs #205

Merged
merged 1 commit into from
Sep 8, 2022
Merged

fix(FEC-12539): Shaka text displayer font size too small on TVs #205

merged 1 commit into from
Sep 8, 2022

Conversation

JonathanTGold
Copy link
Contributor

Description of the Changes

issue: on TV chome don't work in full-screen mode, so the: fullscreen css doesn’t apply
fix: add media query

solves: FEC-12539

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@JonathanTGold JonathanTGold merged commit eaa0949 into master Sep 8, 2022
@giladna giladna deleted the FEC-12539 branch September 8, 2022 10:16
@JonathanTGold JonathanTGold mentioned this pull request Oct 3, 2022
Merged
5 tasks
JonathanTGold added a commit that referenced this pull request Oct 3, 2022
@JonathanTGold
fix(FEC-12622): Revert - TV font size bug fixes - regression (#214)
1ef471b 
Revert - TV font size bug fixes - regression

revert all prsrelated to this bug: #208 #210 #205

solves: FEC-12622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SivanA-Kaltura SivanA-Kaltura SivanA-Kaltura approved these changes

@giladna giladna Awaiting requested review from giladna

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JonathanTGold @SivanA-Kaltura