Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-10548): Low-Latency support #180

Merged
merged 1 commit into from
Jan 31, 2022
Merged

feat(FEC-10548): Low-Latency support #180

merged 1 commit into from
Jan 31, 2022

Conversation

yairans
Copy link
Contributor

@yairans yairans commented Jan 30, 2022

Description of the Changes

pass streaming.lowLatencyMode to shaka

Solves FEC-10548

Related to kaltura/playkit-js#631

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@yairans yairans requested a review from a team January 30, 2022 16:40
@yairans yairans self-assigned this Jan 30, 2022
adapterConfig.forceBreakStall = Utils.Object.getPropertyPath(config, 'streaming.forceBreakStall');
adapterConfig.shakaConfig.streaming.lowLatencyMode = Utils.Object.getPropertyPath(config, 'streaming.lowLatencyMode');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the default set ?
I didnt see what the shaka default is in their docs

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, in playkit, ok

@JonathanTGold JonathanTGold self-requested a review January 31, 2022 09:07
@yairans yairans merged commit f28fb91 into master Jan 31, 2022
@yairans yairans deleted the FEC-10548 branch January 31, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants