Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FEC-10840): incorrect waiting and playing event comes from dash adapter #128

Merged
merged 2 commits into from
Jan 19, 2021
Merged

fix(FEC-10840): incorrect waiting and playing event comes from dash adapter #128

merged 2 commits into from
Jan 19, 2021

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Jan 18, 2021 •
edited by OrenMe
Loading

Description of the Changes

Issue: adapter fire waiting and playing before it fired from the video element.
There is an incorrect situation when playing fired twice for DRM content and waiting fired before play.
Solution: use this mechanism only after first playing to make sure that buffering will be handled after first playing when buffering should change the buffering state.

Solves FEC-10840

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@Yuvalke
fix(FEC-10840): waiting and playing firing before play/playing
8b00fdb 
Issue: adapter fire waiting and playing before it fired from video element.
There is incorrect situation when playing fired twice for drm content and waiting fired before play.
Solution: use this mechanism only after first playing to make sure that buffering will be handled on after first playing when buffering should change the buffering state.
@Yuvalke Yuvalke requested a review from a team January 18, 2021 17:01
@Yuvalke Yuvalke self-assigned this Jan 18, 2021
@Yuvalke Yuvalke changed the title fix(FEC-10840): waiting and playing firing before play/playing fix(FEC-10840): waiting and playing firing before play/playing fires from video element Jan 18, 2021
@Yuvalke Yuvalke changed the title fix(FEC-10840): waiting and playing firing before play/playing fires from video element fix(FEC-10840): waiting and playing dispatch before play/playing fires from video element Jan 18, 2021
@Yuvalke Yuvalke changed the title fix(FEC-10840): waiting and playing dispatch before play/playing fires from video element fix(FEC-10840): incorrect waiting and playing event comes from dash adapter Jan 18, 2021
yairans
yairans previously approved these changes Jan 18, 2021
View reviewed changes
@Yuvalke Yuvalke merged commit fb7ecba into master Jan 19, 2021
@Yuvalke Yuvalke deleted the FEC-10840 branch January 19, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrenMe OrenMe OrenMe approved these changes

@yairans yairans yairans left review comments

Assignees

@Yuvalke Yuvalke

Labels
Type: Bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yuvalke @OrenMe @yairans