Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-10435): upgrade shaka for fixing live issue and optimizations for smartTV #115

Merged
merged 3 commits into from
Sep 2, 2020

Conversation

Yuvalke
Copy link
Contributor

@Yuvalke Yuvalke commented Sep 2, 2020

Description of the Changes

Issue: encrypted liner channel sometimes constantly changes from buffering to playing
Solution: upgrade shaka - fixes for live and smartTV optimizations - added fixes for test and change the default bufferingGoal to 60s as we have for HLS.
remove _getCurrentSegmentLength which calculated from a recent segment that doesn't fit shaka calculation which used getMaxSegmentDuration instead.

Solve: FEC-10435.

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

…s for smartTV

Issue: encrypted liner channel sometimes constantly changes from buffering to playing
Solution: upgrade shaka - fixes for live and smartTV optimizations - added fixes for test and change the default bufferingGoal to 60s as we have for hls.

Solve: FEC-10435.
@Yuvalke Yuvalke requested a review from a team September 2, 2020 08:38
@Yuvalke Yuvalke self-assigned this Sep 2, 2020
@Yuvalke Yuvalke merged commit 40af1c8 into master Sep 2, 2020
@Yuvalke Yuvalke deleted the FEC-10435 branch September 2, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants